Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable obscuroscan test #1566

Merged
merged 3 commits into from
Oct 2, 2023
Merged

Enable obscuroscan test #1566

merged 3 commits into from
Oct 2, 2023

Conversation

otherview
Copy link
Contributor

Why this change is needed

As per description

What changes were made as part of this PR

Please provide a high level list of the changes made

PR checks pre-merging

Please indicate below by ticking the checkbox that you have read and performed the required
PR checks

  • PR checks reviewed and performed

@otherview otherview requested a review from zkokelj October 2, 2023 09:20
zkokelj
zkokelj approved these changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@zkokelj zkokelj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just minor comment added

integration/obscuroscan/obscuroscan_test.go Outdated Show resolved Hide resolved
@otherview otherview merged commit 701bd07 into main Oct 2, 2023
@otherview otherview deleted the pedro/enable_obs_scan_test branch October 2, 2023 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zkokelj zkokelj zkokelj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@otherview @zkokelj